New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication improvements #2573

Merged
merged 11 commits into from Aug 2, 2016

Conversation

Projects
None yet
3 participants
@edmundoa
Member

edmundoa commented Aug 1, 2016

This PR contains several fixes and improvements to authentication pages:

  • Fix issue #2572
  • Simplify AuthenticationComponent
  • Use local styles to avoid clashes with other global styles
  • Unify UI across all components involved in the new authentication page
  • Other small improvements

edmundoa added some commits Aug 1, 2016

Let authentication active tab handling to react-bootstrap
Simplify the component by relying on react-bootstrap to select the
right pill.
Use local styles in authentication tab
Avoiding clashes with outer styling.
Do not load LDAP configuration on store init
Instead, get the configuration when loading the component.

Fixes #2572
Improve feedback on read only users
Make more clear why read only users cannot be edited, and where they
should be edited instead.
Unify authentication pages appearence
- Use same colours on buttons
- Put buttons on the same place
- Add cancel buttons to all forms
Do not show error when LDAP groups returns a 400
That is used when LDAP is not configured or disabled, and in those cases
we already show an informative message in the screen.

@edmundoa edmundoa added this to the 2.1.0 milestone Aug 1, 2016

@joschi joschi self-assigned this Aug 2, 2016

@kroepke

This comment has been minimized.

Member

kroepke commented Aug 2, 2016

lgtm!

@kroepke kroepke merged commit 686ab28 into master Aug 2, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1189 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 672 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kroepke kroepke deleted the authentication-fixes branch Aug 2, 2016

@joschi joschi assigned kroepke and unassigned joschi Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment