New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for Forbidden APIs in default build profile #2574

Merged
merged 11 commits into from Aug 3, 2016

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Aug 1, 2016

This PR moves the Forbidden APIs check into the default build profile (was in the (P)edantic profile before) and activates the plugin to fail builds on violation.

Additionally, this PR updates the Forbidden APIs signatures and fixes all violations in the current Graylog codebase.

@joschi joschi added this to the 2.1.0 milestone Aug 1, 2016

@joschi

This comment has been minimized.

Contributor

joschi commented Aug 1, 2016

Refs #2567

@kroepke

This comment has been minimized.

Member

kroepke commented Aug 3, 2016

lgtm!

@kroepke kroepke merged commit 043fa60 into master Aug 3, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1191 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 674 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@kroepke kroepke deleted the forbidden-apis branch Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment