New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes with prefixed URLs #2583

Merged
merged 2 commits into from Aug 2, 2016

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Aug 2, 2016

This PR includes fixes for these issues:

  • Some components use routes from ApiRoutes, which is not the right place for them, as they are not properly prefixed
  • Adding an app prefix breaks the selected system page that is displayed in the navigation bar

edmundoa added some commits Aug 2, 2016

Move web interface routes from ApiRoutes to Routes
ApiRoutes should not contain links to web interface routes, as they are
not properly prefixed.

@edmundoa edmundoa added this to the 2.1.0 milestone Aug 2, 2016

@bernd bernd self-assigned this Aug 2, 2016

@bernd

This comment has been minimized.

Member

bernd commented Aug 2, 2016

LGTM 👍

@bernd bernd merged commit 8aba7ab into master Aug 2, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1195 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 678 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bernd bernd deleted the app-prefix-fixes branch Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment