New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print - instead of null when client did not provide user agent header #2601

Merged
merged 1 commit into from Aug 3, 2016

Conversation

Projects
None yet
2 participants
@mikkolehtisalo
Contributor

mikkolehtisalo commented Aug 3, 2016

HTTP clients not providing user agent header cause "null" to be printed in logs. Found this out when a braindead load balancer product started hammering /system/lbstatus... Just a cosmetic fix.

By the way, responseContext.getLength() can never work at RestAccessLogFilter, because Jersey has not produced the body yet - thus there is no Content-Length available. I think counting responseContext.getEntityStream() might work, that seemed like heavy to me.

@joschi

This comment has been minimized.

Contributor

joschi commented Aug 3, 2016

LGTM. 👍

Thanks!

@joschi joschi self-assigned this Aug 3, 2016

@joschi joschi added this to the 2.1.0 milestone Aug 3, 2016

@joschi joschi added the improvement label Aug 3, 2016

@joschi joschi merged commit cc6c7af into Graylog2:master Aug 3, 2016

3 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1212 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 695 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment