New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTP and HTTPS default ports for network settings #2605

Merged
merged 2 commits into from Aug 4, 2016

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Aug 3, 2016

Description

The network settings in the Graylog configuration should use the default ports for the configured URI scheme if no custom port was given.

Motivation and Context

Currently users struggle with the non-standard handling of ports in the rest_listen_uri, rest_transport_uri, and web_listen_uri configuration settings. People are used to not type in the default ports for HTTP and HTTPS URIs, e. g. http://www.example.com instead of http://www.example.com:80.

Refs #2595

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joschi joschi added this to the 2.1.0 milestone Aug 3, 2016

@bernd bernd self-assigned this Aug 4, 2016

@bernd

This comment has been minimized.

Member

bernd commented Aug 4, 2016

LGTM 👍

@bernd bernd merged commit 515c7f8 into master Aug 4, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1215 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 698 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bernd bernd deleted the issue-2595 branch Aug 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment