New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow web_endpoint_uri to be a relative URI #2614

Merged
merged 2 commits into from Aug 8, 2016

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Aug 4, 2016

The changes in PR #2600 restricted web_endpoint_uri to an absolute URI, which makes some use cases impossible to implement: #2600 (comment)

This PR reverts this specific validation for the web_endpoint_uri configuration setting.

@joschi joschi added this to the 2.1.0 milestone Aug 4, 2016

@bernd

This comment has been minimized.

Member

bernd commented Aug 8, 2016

LGTM 👍

@bernd bernd merged commit 6511c20 into master Aug 8, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1218 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 701 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bernd bernd deleted the web-endpoint-uri-relative branch Aug 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment