New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use default session attribute for principal #2621

Merged
merged 1 commit into from Aug 8, 2016

Conversation

Projects
None yet
2 participants
@kroepke
Member

kroepke commented Aug 5, 2016

Description

the SessionResource set a custom session attribute to find the name of the user owning the session, but the if auth plugins forced a session creation that wasn't set.
Instead of trying to fix the auth plugins, rely on a shiro framework attribute to get the principal

Motivation and Context

fixes #2620

How Has This Been Tested?

Use the SSO plugin and a proxy setting a auth header.
Before the change users that logged in via the SSO plugin aren't show as having an active session in the Users list.
After the change the users' sessions can be found and they are shown as logged in.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
use default session attribute for principal
the SessionResource set a custom session attribute to find the name of the user owning the session, but the if auth plugins forced a session creation that wasn't set.
Instead of trying to fix the auth plugins, rely on a shiro framework attribute to get the principal

fixes #2620

@kroepke kroepke added this to the 2.1.0 milestone Aug 5, 2016

@bernd bernd self-assigned this Aug 8, 2016

@bernd

This comment has been minimized.

Member

bernd commented Aug 8, 2016

LGTM 👍

@bernd bernd merged commit d6f32ff into master Aug 8, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1221 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 704 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bernd bernd deleted the fix-principal-session-attr branch Aug 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment