New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloning streams and editing legacy stream rules #2646

Merged
merged 2 commits into from Aug 10, 2016

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Aug 9, 2016

  • The "description" field of stream rules wasn't cloned when cloning streams,
  • The "description" field in the CreateStreamRuleRequest class wasn't nullable which effectively prevented editing legacy stream rules without any description.

Refs #2244
Fixes #2346

joschi added some commits Aug 9, 2016

Make CreateStreamRuleRequest#description() nullable
The "description" field of stream rules has to be nullable because otherwise
legacy stream rules with no description cannot be edited anymore.

Refs #2244, fixes #2346

@joschi joschi added this to the 2.1.0 milestone Aug 9, 2016

@bernd bernd self-assigned this Aug 10, 2016

@bernd

This comment has been minimized.

Member

bernd commented Aug 10, 2016

LGTM 👍

@bernd bernd merged commit 101bbf7 into master Aug 10, 2016

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ci-server-integration Jenkins build graylog2-server-integration-pr 1233 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 716 has succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bernd bernd deleted the issue-2346 branch Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment