New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add format string message decorator #2660

Merged
merged 1 commit into from Aug 15, 2016

Conversation

Projects
None yet
2 participants
@kroepke
Member

kroepke commented Aug 11, 2016

this uses the JMTE template engine to create synthetic fields at search time
useful for scenarios where the messages are fully decomposed, but a nicer human readable name is required during presentation

add format string message decorator
this uses the JMTE template engine to create synthetic fields at search time
useful for scenarios where the messages are fully decomposed, but a nicer human readable name is required during presentation

@kroepke kroepke added this to the 2.1.0 milestone Aug 11, 2016

@dennisoelkers dennisoelkers self-assigned this Aug 11, 2016

@dennisoelkers

This comment has been minimized.

Member

dennisoelkers commented Aug 11, 2016

Would you mind doing a quick auto-indent? The indentation looks off and inconsistent.

@kroepke

This comment has been minimized.

Member

kroepke commented Aug 12, 2016

@dennisoelkers which do you mean? This is my standard indentation I always use.
The line breaks are probably because of the relatively long lines due to the 120 char column.

I still have an open task for proposing a project-wide code style guide we all use, but until then I think we could postpone the decision on this?

@dennisoelkers dennisoelkers merged commit 1c9c6c0 into master Aug 15, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1247 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 730 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dennisoelkers dennisoelkers deleted the format-string-decorator branch Aug 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment