Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run WebAppNotFoundResponseFilter later and for GET requests only. #2664

Merged
merged 3 commits into from Aug 11, 2016

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Aug 11, 2016

Description

This change forces the CORSFilter to run before in the post phase,
so the CORS headers are added. It also skips the
WebAppNotFoundResponseFilter for non-get requests.

Motivation and Context

The WebAppNotFoundResponseFilter running before the CORSFilter causes
the latter to skip adding CORS headers for OPTIONS requests.

How Has This Been Tested?

Manually.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fixes #2657

The WebAppNotFoundResponseFilter running before the CORSFilter causes
the latter to skip adding CORS headers for OPTIONS requests.

This change forces the CORSFilter to run before in the post phase,
so the CORS headers are added. It also skips the
WebAppNotFoundResponseFilter for non-get requests.

Fixes #2657
@dennisoelkers dennisoelkers added this to the 2.1.0 milestone Aug 11, 2016
@edmundoa
Copy link
Member

@edmundoa edmundoa commented Aug 11, 2016

LGTM 👍

@edmundoa edmundoa merged commit 33af544 into master Aug 11, 2016
4 checks passed
4 checks passed
@garybot2
ci-server-integration Jenkins build graylog2-server-integration-pr 1251 has succeeded
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 734 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@edmundoa edmundoa deleted the issue-2657 branch Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants