New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move decorator help link to bottom #2666

Merged
merged 5 commits into from Aug 16, 2016

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Aug 11, 2016

Description

This PR moves the decorator help link below the select box used to create decorators and lets it float to the right. It also removes the glyph in the help link and aligns it with the right border of the other elements.

Motivation and Context

Without the change the help link looked misplaced.

Screenshots (if appropriate):

Before:
screen shot 2016-08-11 at 16 03 44

After:
screen shot 2016-08-16 at 13 54 23

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@edmundoa

This comment has been minimized.

Member

edmundoa commented Aug 11, 2016

I really dislike that new positioning. In first place there are three elements to click in a really small space, in the second place, the link breaks the flow of all the other elements. On top of that the link is not aligned with the other elements on the screen.

If the problem is that the link at the top looks odd with the tabs, or is just too prominent, I suggest moving it below the add decorator dropdown, but leaving it on the left. We could change the icon to be on the left, as we do in many other places for better consistency.

@dennisoelkers

This comment has been minimized.

Member

dennisoelkers commented Aug 12, 2016

This is why I like it, it creates a separation between the action (creating a new decorator) and the list of items, which works so well because of the white space on the left side between the select box and the list items. It makes the whole box appear more airy and less crammed than before.

I would be fine with moving the glyph to the left of the text though and remove a bit of padding on the right end of the link to align it with the right ending of the other elements.

@edmundoa edmundoa self-assigned this Aug 15, 2016

@edmundoa

This comment has been minimized.

Member

edmundoa commented Aug 15, 2016

I still personally like the link on the left side better, but in the end it's a matter of taste and opinion, so let's agree to disagree.

I am basically fine with the change if we align the link to the right with the other elements in the sidebar. Regarding the font-awesome icon, my current thinking is that we don't really need it, and that it looks odd. I added it for consistency with other help links, but this one is already a question that looks like a link, so adding the icon doesn't provide much value in my opinion.

@dennisoelkers dennisoelkers force-pushed the move-decorator-help-link-to-bottom branch from d29bf44 to d80688b Aug 16, 2016

dennisoelkers added some commits Aug 16, 2016

Moving decorator help link to bottom of container.
The decorator help link currently looks misplaced and weird. This change
is moving it to the bottom of the container and aligns it to the right.

@dennisoelkers dennisoelkers force-pushed the move-decorator-help-link-to-bottom branch from d80688b to 2090b5e Aug 16, 2016

dennisoelkers added some commits Aug 16, 2016

@edmundoa

This comment has been minimized.

Member

edmundoa commented Aug 16, 2016

Looks good to me 👍

@edmundoa edmundoa merged commit bb715db into master Aug 16, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1279 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 762 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@edmundoa edmundoa deleted the move-decorator-help-link-to-bottom branch Aug 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment