New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gzip per default for REST API listener. #2672

Merged
merged 1 commit into from Aug 16, 2016

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Aug 12, 2016

Description

Due to the consolidation of the web and REST API listeners, this setting
is now becoming much more relevant for the performance of the web
interface. GZIP was disabled per default for the REST API in past
versions, which was a very conservative decision. Now that in certain
configurations the REST API listener also serves the web interface, this
setting is very important for performance, as the web interface assets
are quite big when delivering them uncompressed.

As there is no reason (and no negative experience with GZIP in the
past), it is now enabled per default.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fixes #2670

Enable gzip per default for REST API listener.
Due to the consolidation of the web and REST API listeners, this setting
is now becoming much more relevant for the performance of the web
interface. GZIP was disabled per default for the REST API in past
versions, which was a very conservative decision. Now that in certain
configurations the REST API listener also serves the web interface, this
setting is very important for performance, as the web interface assets
are quite big when delivering them uncompressed.

As there is no reason (and no negative experience with GZIP in the
past), it is now enabled per default.

Fixes #2670

@dennisoelkers dennisoelkers added this to the 2.1.0 milestone Aug 12, 2016

@bernd bernd self-assigned this Aug 16, 2016

@bernd

This comment has been minimized.

Member

bernd commented Aug 16, 2016

LGTM 👍

File sizes are back to the level before the network changes.

Before

image

After

image

@bernd bernd merged commit 1607670 into master Aug 16, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1259 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 742 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bernd bernd deleted the enable-gzip-for-rest-api-per-default branch Aug 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment