New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused prop type in StreamRuleList component. #2673

Merged
merged 1 commit into from Aug 12, 2016

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Aug 12, 2016

Motivation and Context

There was an unused prop type defined in the StreamRuleList component,
which was not passed to it, therefore generating a warning in the
browser's console for every use of the component. This change removes
the prop type.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Removing unused prop type in StreamRuleList component.
There was an unused prop type defined in the StreamRuleList component,
which was not passed to it, therefore generating a warning in the
browser's console for every use of the component. This change removes
the prop type.

@dennisoelkers dennisoelkers added this to the 2.1.0 milestone Aug 12, 2016

@edmundoa

This comment has been minimized.

Member

edmundoa commented Aug 12, 2016

LGTM 👍

@edmundoa edmundoa self-assigned this Aug 12, 2016

@edmundoa edmundoa merged commit c005ac0 into master Aug 12, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1260 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 743 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@edmundoa edmundoa deleted the remove-unnecessary-prop-type branch Aug 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment