New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating a relative redirect URL for web interface in root resource. #2675

Merged
merged 3 commits into from Aug 16, 2016

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Aug 12, 2016

Description

Using the web_listen_uri to generate the redirect to the web interface
could lead to problems in case it is not accessible from the client.
Therefore we are generating a relative URL instead.

Fixes #2593.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Generating a relative redirect URL for web interface in root resource.
Using the `web_listen_uri` to generate the redirect to the web interface
could lead to problems in case it is not accessible from the client.
Therefore we are generating a relative URL instead.

@joschi joschi self-assigned this Aug 16, 2016

@joschi

This comment has been minimized.

Contributor

joschi commented Aug 16, 2016

LGTM. 👍

@joschi joschi merged commit 9b08f3d into master Aug 16, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1263 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 746 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@joschi joschi deleted the fix-root-resource-redirect-to-web-if branch Aug 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment