New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show notification link when there are notifications #2677

Merged
merged 1 commit into from Aug 16, 2016

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Aug 12, 2016

Previously the navbar didn't contain a badge with the system notification count, but a link was still visible (the cursor changed when hovering), even if clicking didn't do anything.

Only show notification link when there are notifications
Previously the navbar didn't contain a badge with the system
notification count, but a link was still visible (the cursor changed
when hovering), even if clicking didn't do anything.

@edmundoa edmundoa added this to the 2.1.0 milestone Aug 12, 2016

@dennisoelkers dennisoelkers merged commit 27b260a into master Aug 16, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1266 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 749 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dennisoelkers dennisoelkers deleted the hide-notification-count branch Aug 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment