New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in raw message loader #2684

Merged
merged 1 commit into from Aug 16, 2016

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Aug 15, 2016

These are the improvements done in the raw message loader:

  • Use 127.0.0.1 as default remote address, making the field optional
  • Do not use a fieldset for message input, as it only contains a single input
  • Mark message input field as optional
  • Mark required fields as required, to enable browser validation
Improvements in raw message loader
- Use 127.0.0.1 as default remote address, making the field optional
- Do not use an own fieldset for message input, as it will only contain
  a single input
- Mark message input field as optional
- Mark required fields as required, to enable browser validation

@edmundoa edmundoa added this to the 2.1.0 milestone Aug 15, 2016

@bernd bernd self-assigned this Aug 16, 2016

@bernd

This comment has been minimized.

Member

bernd commented Aug 16, 2016

LGTM 👍

@bernd bernd merged commit 78063ba into master Aug 16, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1268 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 751 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@bernd bernd deleted the raw-message-loader-improvements branch Aug 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment