New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help text for session's client address #2692

Merged
merged 4 commits into from Aug 16, 2016

Conversation

Projects
None yet
2 participants
@kroepke
Member

kroepke commented Aug 16, 2016

The auth framework does not support updating sessions beyond the last used timestamp.
Especially the host is not resettable after creation.

Users might expect the address to change, but if we want to expose that we need to save this information separately in the future.

This change merely informs the user about this circumstance and makes the headers available internally for some optimization regarding session extension (less DB requests).

Refs #2656

kroepke added some commits Aug 15, 2016

make the request headers available in authenticators
do not extend sessions for proxied requests (the initial request has already done that, reduces db traffic)
add explanation for client address
sessions do not update the client address, add some help text

@kroepke kroepke added this to the 2.1.0 milestone Aug 16, 2016

private final DefaultSecurityManager securityManager;
private Provider<Request> grizzlyRequestProvider;
private final Set<IpSubnet> trustedProxies;
public static final String X_GRAYLOG_REMOTE_ADDRESS = "x-graylog-remote-address";

This comment has been minimized.

@joschi

joschi Aug 16, 2016

Contributor

What is this constant being used for?

This comment has been minimized.

@kroepke

kroepke Aug 16, 2016

Member

Apparently left over. If unused I'll remove it.

let actions = null;
if (user.read_only) {
const tooltip = <Tooltip id="system-user">System users can only be modified in the Graylog configuration file.</Tooltip>;

This comment has been minimized.

@joschi

joschi Aug 16, 2016

Contributor

Unnecessary whitespace change.

@@ -90,11 +105,13 @@ const UserList = React.createClass({
</OverlayTrigger>);
}
const roleBadges = user.roles.map((role) => <span key={role} className={`${UserListStyle.roleBadgeFixes} label label-${role === 'Admin' ? 'info' : 'default'}`} >{role}</span>);

This comment has been minimized.

@joschi

joschi Aug 16, 2016

Contributor

Unnecessary whitespace change.

@joschi joschi self-assigned this Aug 16, 2016

@joschi

This comment has been minimized.

Contributor

joschi commented Aug 16, 2016

LGTM. 👍

@joschi joschi merged commit e07cf4e into master Aug 16, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1278 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 761 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@joschi joschi deleted the session-host branch Aug 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment