New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset users' startpages if referenced stream/dashboard is deleted. #2695

Merged
merged 3 commits into from Aug 16, 2016

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Aug 16, 2016

Description

This change adds a listener and the necessary events, which are posted
when a stream or dashboard is deleted. The listener will then reset any
user's startpage if it references the deleted entity.

Also the StartPage component reloads the current user before redirecting, so the start page reset also affects logged in users.

Motivation and Context

As described in #2400, when a user has set a dashboard/stream as start page and that entity is deleted, the user gets an error every login/click on the Graylog logo on the upper left.

Fixes #2400.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

dennisoelkers added some commits Aug 16, 2016

Add Listener to reset users' startpages if stream/dashboard is deleted.
This change adds a listener and the necessary events, which are posted
when a stream or dashboard is deleted. The listener will then reset any
user's startpage if it references the deleted entity.

@dennisoelkers dennisoelkers added the bug label Aug 16, 2016

@dennisoelkers dennisoelkers added this to the 2.1.0 milestone Aug 16, 2016

@joschi

This comment has been minimized.

Contributor

joschi commented Aug 16, 2016

LGTM. 👍

@joschi joschi self-assigned this Aug 16, 2016

@joschi joschi merged commit 9a76e5c into master Aug 16, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1280 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 763 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@joschi joschi deleted the issue-2400 branch Aug 16, 2016

dennisoelkers added a commit that referenced this pull request Aug 17, 2016

Revert "Reset users' startpages if referenced stream/dashboard is del…
…eted. (#2695)"

This reverts commit 9a76e5c.

This change was introducing a bug, that caused the user object in the
web interface to be stale and out of date after a logout/login under a
different username.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment