New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General improvements #2700

Merged
merged 3 commits into from Aug 17, 2016

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Aug 16, 2016

I grouped together in this PR three small changes:

  • Rename "Show Original" button to "Show changes" in decorated message details, which in my humble opinion represents better what the button does
  • Use a larger input to display the message ID in the manual message loader
  • Do not decorate messages loaded with the recent message loader

edmundoa added some commits Aug 16, 2016

Rename "Show Original" button to "Show changes"
The button displays the changes applied by the decorators applied in the
stream, so that name seems more logical to me. Also use consistent case
in the button.
Use larger input for message id field
On the manual message loader, give more width to the message ID
field, so the whole ID is visible.
Do not use decorators in recent message loader
The recent message loader uses a search to get a recent message, and it
was being decorated.

This commit adds another parameter to `UniversalSearchStore.search()` to
indicate whether or not the search should be decorated.

@edmundoa edmundoa added this to the 2.1.0 milestone Aug 16, 2016

@dennisoelkers dennisoelkers self-assigned this Aug 17, 2016

@dennisoelkers dennisoelkers merged commit d9de776 into master Aug 17, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1284 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 767 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dennisoelkers dennisoelkers deleted the ui-improvements branch Aug 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment