Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let specific stores reuse promises if request is in progress. #2712

Merged
merged 1 commit into from Aug 24, 2016
Merged

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Aug 18, 2016

Description

This prevents buildup of requests to server if mttr is too high, which
could lead to overload of server. Instead just wait for the current
request to finish and reuse the currently running one for response
handling.

Fixes #2625.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
This prevents buildup of requests to server if mttr is too high, which
could lead to overload of server. Instead just wait for the current
request to finish and reuse the currently running one for response
handling.

Fixes #2625.
@edmundoa
Copy link
Member

@edmundoa edmundoa commented Aug 24, 2016

LGTM 👍

@edmundoa edmundoa merged commit 79c1d65 into master Aug 24, 2016
4 checks passed
4 checks passed
@garybot2
ci-server-integration Jenkins build graylog2-server-integration-pr 1299 has succeeded
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 782 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@edmundoa edmundoa deleted the issue-2625 branch Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants