Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let widget replay search button open in a new tab or window #2726

merged 3 commits into from Aug 24, 2016


Copy link

@edmundoa edmundoa commented Aug 22, 2016

This PR fixes issue #2725, by changing the widget replay search button with a link, that allows to be opened in a new tab or window in a more standard way.

I also decided to take care of the long overdue task of moving the logic building the replay URL to the Routes object, which is a better place for it. This still needs a bit of clean up, as the incomplete (and now unnecessary) Routes.search_with_query is not needed any more, but is still used in the collector plugin. I'll take care of removing the call on the plugin and cleaning up the function afterwards.

edmundoa added 3 commits Aug 22, 2016
Convert the button in the `WidgetFooter` component on a link, that receives
the href property from the parent component.
It's better to let `Routes` handle the generation of the replay widget
URL, and this moves the logic to do that.

The change adds the capability to get search or stream search routes
with (optional) query, time range, and resolution parameters. The
incomplete `search_with_query` function is still used in the collector
plugin, so this still needs a bit of cleanup.
@edmundoa edmundoa added this to the 2.1.0 milestone Aug 22, 2016
@dennisoelkers dennisoelkers self-assigned this Aug 22, 2016
@dennisoelkers dennisoelkers merged commit f6578e6 into master Aug 24, 2016
4 checks passed
4 checks passed
ci-server-integration Jenkins build graylog2-server-integration-pr 1303 has succeeded
ci-web-linter Jenkins build graylog-pr-linter-check 786 has succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@dennisoelkers dennisoelkers deleted the issue-2725 branch Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants