New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NPE and verbose logging if converter returns null #2729

Merged
merged 1 commit into from Aug 23, 2016

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Aug 23, 2016

Converters can return null which should be properly handled by the Extractor class instead of just catching the "exception" (which really isn't one).

Refs #2717

@joschi joschi added this to the 2.1.0 milestone Aug 23, 2016

@joschi joschi force-pushed the issue-2717-npe branch from dde7da6 to 22ede2a Aug 23, 2016

@edmundoa edmundoa self-assigned this Aug 23, 2016

@edmundoa

This comment has been minimized.

Member

edmundoa commented Aug 23, 2016

LGTM 👍

@edmundoa edmundoa merged commit ee9653a into master Aug 23, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1305 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 788 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@edmundoa edmundoa deleted the issue-2717-npe branch Aug 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment