Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make id field consistent for alarm callback histories. #2737

Merged
merged 1 commit into from Aug 24, 2016

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Aug 24, 2016

Changes id field in REST representation of alarm callback histories from
"_id" to "id" to make this more consistent with other entities.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Changes id field in REST representation of alarm callback histories from
"_id" to "id" to make this more consistent with other entities.
@dennisoelkers dennisoelkers added this to the 2.1.0 milestone Aug 24, 2016
@bernd
Copy link
Member

@bernd bernd commented Aug 24, 2016

Does that still work with older alarm callback history entries?

Loading

@dennisoelkers
Copy link
Member Author

@dennisoelkers dennisoelkers commented Aug 24, 2016

Yes.

Loading

@bernd bernd self-assigned this Aug 24, 2016
@bernd
Copy link
Member

@bernd bernd commented Aug 24, 2016

LGTM 👍

Loading

@bernd bernd merged commit 526ce07 into master Aug 24, 2016
2 checks passed
Loading
@bernd bernd deleted the fix-id-field-for-alarm-callback-histories branch Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants