New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling of decorator list #2744

Merged
merged 3 commits into from Aug 25, 2016

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Aug 25, 2016

This PR includes two changes in the decorator sidebar styling:

  • Allow scrolling when list of decorators overflows the screen height. Fixes #2743
  • Do not include help link in the drag preview of the first decorator

edmundoa added some commits Aug 25, 2016

Do not move decorator help link with first decorator
Using padding with the scrollable list item takes that space as part of
the preview that gets dragged, and in this case it includes the help
link.

This change gives height to the help link container instead, fixing the
display issue.

@edmundoa edmundoa added this to the 2.1.0 milestone Aug 25, 2016

@bernd bernd self-assigned this Aug 25, 2016

@bernd

This comment has been minimized.

Member

bernd commented Aug 25, 2016

Tested and LGTM 👍

@bernd bernd merged commit a1ffa80 into master Aug 25, 2016

0 of 4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1323 is running
Details
ci-web-linter Jenkins build is being scheduled
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@bernd bernd deleted the issue-2743 branch Aug 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment