Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidating widget result cache cluster wide when a widget changes. #2745

Merged
merged 15 commits into from Aug 29, 2016

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Aug 25, 2016

Description

Before this, a change to a widget done on one node was not reflected
correctly on other nodes, due to the widget being cached in the
WidgetResultsCache.

This change now creates and tracks widget update events cluster-wide and
invalidates the local caches accordingly.

Fixes #2732.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Before this, a change to a widget done on one node was not reflected
correctly on other nodes, due to the widget being cached in the
WidgetResultsCache.

This change now creates and tracks widget update events cluster-wide and
invalidates the local caches accordingly.

Fixes #2732.
@@ -1,5 +1,5 @@
window.appConfig = {
gl2ServerUrl: 'http://localhost:9000/api',
gl2ServerUrl: 'http://localhost:12900/',

This comment has been minimized.

@joschi

joschi Aug 29, 2016
Contributor

This shouldn't be committed.

@joschi
Copy link
Contributor

@joschi joschi commented Aug 29, 2016

I don't think it is a good idea to publish the events in DashboardsResource and would prefer this happening in DashboardServiceImpl.

This being said, I'll merge this PR to get the functionality into Graylog 2.1.0 and moving the event publishing into DashboardServiceImpl would require a larger refactoring of said class.

@joschi joschi merged commit 00881b9 into master Aug 29, 2016
4 checks passed
4 checks passed
@garybot2
ci-server-integration Jenkins build graylog2-server-integration-pr 1334 has succeeded
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 817 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@joschi joschi deleted the issue-2732 branch Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants