New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use the bluebird promise in FetchProvider #2762

Merged
merged 1 commit into from Aug 31, 2016

Conversation

Projects
None yet
2 participants
@bernd
Member

bernd commented Aug 31, 2016

Previously this was returning a native Promise when SessionStore.isLoggedIn() returned false.

Fixes NodesStore which failed when trying to call finally() on a native

pasted image at 2016_08_31 16_21
promise.

Actually use the bluebird promise in FetchProvider
Previously this was returning a native Promise when
SessionStore.isLoggedIn() returned false.

Fixes NodesStore which failed when trying to call finally() on a native
promise.

@bernd bernd added this to the 2.1.0 milestone Aug 31, 2016

@edmundoa edmundoa self-assigned this Aug 31, 2016

@edmundoa

This comment has been minimized.

Member

edmundoa commented Aug 31, 2016

LGTM 👍

@edmundoa edmundoa merged commit 85371c6 into master Aug 31, 2016

4 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1339 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 822 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@edmundoa edmundoa deleted the fix-fetch-provider-promise branch Aug 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment