New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly close OkHttp Response objects to avoid resource leaks #2812

Merged
merged 3 commits into from Sep 12, 2016

Conversation

Projects
None yet
3 participants
@joschi
Contributor

joschi commented Sep 12, 2016

@joschi joschi added this to the 2.2.0 milestone Sep 12, 2016

@joschi joschi changed the title from Guard OkHttp response in VersionCheckResponse with try-with-resources to Properly close OkHttp Response objects to avoid resource leaks Sep 12, 2016

@joschi

This comment has been minimized.

Contributor

joschi commented Sep 12, 2016

This PR should be cherry-picked into 2.1 when merged.

@edmundoa edmundoa self-assigned this Sep 12, 2016

@edmundoa

This comment has been minimized.

Member

edmundoa commented Sep 12, 2016

LGTM 👍

@edmundoa edmundoa merged commit 46e84c5 into master Sep 12, 2016

5 checks passed

ci-server-integration Jenkins build graylog2-server-integration-pr 1360 has succeeded
Details
ci-web-linter Jenkins build graylog-pr-linter-check 843 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

edmundoa added a commit that referenced this pull request Sep 12, 2016

Properly close OkHttp Response objects to avoid resource leaks (#2812)
* Guard OkHttp response in VersionCheckResponse with try-with-resources

Refs #2811

* Properly close OkHttp Response objects

* Fix invalid URL handling in HTTPAlarmCallback

(cherry picked from commit 46e84c5)

@edmundoa edmundoa deleted the version-check-resource-leak branch Sep 12, 2016

@jdonnelly-apixio

This comment has been minimized.

jdonnelly-apixio commented Feb 15, 2017

Does this fix address the issue that causes the browser to wait for available sockets?

@joschi

This comment has been minimized.

Contributor

joschi commented Feb 16, 2017

@sre-jon No. If you have found a bug in Graylog, please open another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment