Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ValidatorProvider a Singleton #3038

Merged
merged 1 commit into from Nov 2, 2016
Merged

Make ValidatorProvider a Singleton #3038

merged 1 commit into from Nov 2, 2016

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Nov 2, 2016

Closes #3019

(cherry picked from commit b82ca3e)

The Validator instance creation is quite expensive. Making this a
Singleton reduced the CPU load by 50% and reduced the GC load from 5 GCs
per second to 2 GCs per second when running a load test of the collector
registration endpoint.

Closes #3019

(cherry picked from commit b82ca3e)
@joschi joschi added this to the 2.1.2 milestone Nov 2, 2016
@kroepke
kroepke approved these changes Nov 2, 2016
@kroepke kroepke merged commit 6b891a9 into 2.1 Nov 2, 2016
5 checks passed
5 checks passed
@garybot2
ci-server-integration Jenkins build graylog2-server-integration-pr 1505 has succeeded
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 987 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@kroepke kroepke deleted the issue-3019 branch Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants