Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading of web plugins in development mode #3185

Merged
merged 1 commit into from Dec 12, 2016
Merged

Conversation

@bernd
Copy link
Member

@bernd bernd commented Dec 12, 2016

Get the plugin name from the package.json file or the parent directory name instead of just splitting the path and taking a "random" element.

Also do not include webpack configurations from the node_modules and target directories.

Get the plugin name from the package.json file or the parent directory
name instead of just splitting the path and taking a "random" element.

Also do not include webpack configurations from the node_modules and
target directories.
@bernd bernd added this to the 2.2.0 milestone Dec 12, 2016
@bernd bernd requested a review from edmundoa Dec 12, 2016
@edmundoa edmundoa self-assigned this Dec 12, 2016
Copy link
Member

@edmundoa edmundoa left a comment

LGTM 👍

@edmundoa edmundoa merged commit d4ecf44 into master Dec 12, 2016
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1127 has succeeded
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@edmundoa edmundoa deleted the fix-webpack-dev-server branch Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants