New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labels on field graphs #3204

Merged
merged 2 commits into from Dec 14, 2016

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Dec 14, 2016

This PR fixes two problems with the statistical functions displayed in field graphs:

  • After merging two field graphs, one of the graphs may end up labelling the line with the wrong statistical function
  • Changing the statistical function of a field graph is not correctly reflected in the hover information for that graph. To test this, you can create a field graph, change the statistical function, hover over the graph, and see that the function displayed there does not match the one previously selected

Fixes #3187

edmundoa added some commits Dec 14, 2016

Fix statistical function when merging charts
Do not convert the statistical function in the series, as it is already
using the right text.

@edmundoa edmundoa added this to the 2.2.0 milestone Dec 14, 2016

@bernd bernd self-assigned this Dec 14, 2016

@bernd

bernd approved these changes Dec 14, 2016

LGTM 👍

@bernd bernd merged commit 04a5a83 into master Dec 14, 2016

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1147 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@bernd bernd deleted the issue-3187 branch Dec 14, 2016

@bernd bernd removed the ready-for-review label Dec 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment