Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts cleanup #3205

Merged
merged 2 commits into from Dec 14, 2016
Merged

Alerts cleanup #3205

merged 2 commits into from Dec 14, 2016

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Dec 14, 2016

Remove unused code after rebuilding much of the alerts UI. Checks another box in #3178.

edmundoa added 2 commits Dec 14, 2016
Previously, we fetched the available callback types per stream, using
`AlarmCallbacksActions` and `AlarmCallbacksStore`, but now we only need
to get them globally, and we can do that by using
`AlertNotificationsActions` and `AlertNotificationsStore`.
These components were replaced with those under `alertnotifications`.
@edmundoa edmundoa added this to the 2.2.0 milestone Dec 14, 2016
@edmundoa edmundoa mentioned this pull request Dec 14, 2016
8 tasks done
@bernd bernd self-assigned this Dec 14, 2016
@bernd
bernd approved these changes Dec 14, 2016
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd merged commit f07f043 into master Dec 14, 2016
4 checks passed
4 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1148 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@bernd bernd deleted the alerts-cleanup branch Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants