Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quickvalues and field statistics refresh #3206

Merged
merged 1 commit into from Dec 14, 2016
Merged

Fix quickvalues and field statistics refresh #3206

merged 1 commit into from Dec 14, 2016

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Dec 14, 2016

Before this change, resetting forceFetch to false in AppWithSearchBar had no immediate effect, as it required a re-render for the new value to be passed to all children. The effect was that we were fetching data more times than needed.

This PR moves forceFetch to the state of AppWithSearchBar, so once we reset the value to false, all children will see the new value and stop refreshing their data.

Fixes #3086

Before this change, resetting `forceFetch` to `false` in
`AppWithSearchBar` had no immediate effect, as it required a re-render
for the new value to be passed to all children. The effect was that we
were fetching data more times than needed.

This commit moves `forceFetch` to the state of `AppWithSearchBar`, so
once we reset the value to `false`, all children will see the new value
and stop refreshing their data.

Fixes #3086
@edmundoa edmundoa added this to the 2.2.0 milestone Dec 14, 2016
@bernd bernd self-assigned this Dec 14, 2016
@bernd
bernd approved these changes Dec 14, 2016
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd merged commit 6271a79 into master Dec 14, 2016
4 checks passed
4 checks passed
ci-web-linter Jenkins build graylog-pr-linter-check 1149 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@bernd bernd deleted the issue-3086 branch Dec 14, 2016
@bernd bernd removed the ready-for-review label Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.