New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #3213

Merged
merged 17 commits into from Dec 16, 2016

Conversation

Projects
None yet
2 participants
@edmundoa
Member

edmundoa commented Dec 16, 2016

This PR contains a bunch of UI improvements. Each improvement has its own commit, but here is a summary of the changes:

  • Fix styling of search loading indicator
  • Sort indices in search sidebar modal by name (#2852)
  • Improvements in streams list page, including #3189 and #3191
  • Improvements in index set forms, including #3190
  • Use index set name to go to the details page (#3192)

edmundoa added some commits Dec 13, 2016

Fix loading indicator styling
Use a more specific selector to give precedence to the custom css
over bootstrap classes.
Display all stream actions for default stream
To keep a better visual consistency, display all actions, but disabled
those that are not applicable to the default stream.
Use dot instead of comma
Stream throughput and matching type are not really related.
Remove autoFocus from retention/rotation config
Before they were using individually, but now they are part of a larger
form. They should not take the focus away from the first input of the
form.
Add default label to default stream
Also replace stream status badge with a label, which is more spread over
the UI and takes less space.

Fixes #3191
Improve styling of stream list
- Move status label a bit up for better alignment
- Move action buttons up in the DOM, to avoid overflow problems and also
improve alignment
Ensure index sets are loaded before mounting
Elements inside the stream list require the index sets to be loaded, so
now we wait until the store fetches them.
Improve texts on index set maintenance
Make clearer which actions affect to all index sets or only the current
one.
Add more consistent styling to index set forms
- Display labels always on top of input
- Add some missing labels
- Use same save button colour as in other pages
- Add spacing between sections
Improvements in index set configuration form
- Improved help messages
- Add basic index prefix validation

Refs #3190

@edmundoa edmundoa added this to the 2.2.0 milestone Dec 16, 2016

@bernd bernd self-assigned this Dec 16, 2016

@bernd

This comment has been minimized.

Member

bernd commented Dec 16, 2016

LGTM 👍

@bernd

bernd approved these changes Dec 16, 2016

@bernd bernd merged commit 3fa1ea5 into master Dec 16, 2016

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1158 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@bernd bernd deleted the ui-improvements branch Dec 16, 2016

@bernd bernd removed the ready-for-review label Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment