Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvements #3213

Merged
merged 17 commits into from Dec 16, 2016
Merged

UI improvements #3213

merged 17 commits into from Dec 16, 2016

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Dec 16, 2016

This PR contains a bunch of UI improvements. Each improvement has its own commit, but here is a summary of the changes:

  • Fix styling of search loading indicator
  • Sort indices in search sidebar modal by name (#2852)
  • Improvements in streams list page, including #3189 and #3191
  • Improvements in index set forms, including #3190
  • Use index set name to go to the details page (#3192)
edmundoa added 17 commits Dec 13, 2016
Use a more specific selector to give precedence to the custom css
over bootstrap classes.
To keep a better visual consistency, display all actions, but disabled
those that are not applicable to the default stream.
Stream throughput and matching type are not really related.
Before they were using individually, but now they are part of a larger
form. They should not take the focus away from the first input of the
form.
Also replace stream status badge with a label, which is more spread over
the UI and takes less space.

Fixes #3191
- Move status label a bit up for better alignment
- Move action buttons up in the DOM, to avoid overflow problems and also
improve alignment
Elements inside the stream list require the index sets to be loaded, so
now we wait until the store fetches them.
Make clearer which actions affect to all index sets or only the current
one.
- Display labels always on top of input
- Add some missing labels
- Use same save button colour as in other pages
- Add spacing between sections
- Improved help messages
- Add basic index prefix validation

Refs #3190
@edmundoa edmundoa added this to the 2.2.0 milestone Dec 16, 2016
@bernd bernd self-assigned this Dec 16, 2016
@bernd
Copy link
Member

@bernd bernd commented Dec 16, 2016

LGTM 👍

@bernd
bernd approved these changes Dec 16, 2016
@bernd bernd merged commit 3fa1ea5 into master Dec 16, 2016
4 checks passed
4 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1158 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@bernd bernd deleted the ui-improvements branch Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants