Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create DefaultIndexSetConfig when creating the default index set #3215

Merged
merged 2 commits into from Dec 19, 2016

Conversation

@bernd
Copy link
Member

@bernd bernd commented Dec 16, 2016

Fixes problems with other migrations.

Fixes problems with other migrations.
@bernd bernd added this to the 2.2.0 milestone Dec 16, 2016
Copy link
Contributor

@joschi joschi left a comment

@bernd Should the creation of DefaultIndexSetConfig be removed from V20161215163900_MoveIndexSetDefaultConfig to avoid duplicate creation and prevent possible conflicts?

@joschi joschi self-assigned this Dec 19, 2016
@bernd
Copy link
Member Author

@bernd bernd commented Dec 19, 2016

Should the creation of DefaultIndexSetConfig be removed from V20161215163900_MoveIndexSetDefaultConfig to avoid duplicate creation and prevent possible conflicts?

I will change the migration to check if there is a DefaultIndexSetConfig already. That should avoid the possible problem you mentioned but still allow a working upgrade from an earlier beta.

@joschi
joschi approved these changes Dec 19, 2016
@joschi joschi merged commit 460cac6 into master Dec 19, 2016
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
ci-web-linter Jenkins build graylog-pr-linter-check 1169 has succeeded
Details
licence/cla Contributor License Agreement is signed.
Details
@joschi joschi deleted the fix-default-index-set-creation branch Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.