Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "sender" optional in EmailAlarmCallback #3224

Merged
merged 2 commits into from Dec 22, 2016
Merged

Make "sender" optional in EmailAlarmCallback #3224

merged 2 commits into from Dec 22, 2016

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Dec 21, 2016

The sender field in an email alert callback configuration should be optional. Graylog is using the email address configured in `` as fallback, is the sender field wasn't provided.

Fixes #1512

@joschi joschi added this to the 2.2.0 milestone Dec 21, 2016
@bernd bernd self-assigned this Dec 22, 2016
Copy link
Member

@bernd bernd left a comment

Please adjust the sender test in EmailAlarmCallback#checkConfiguration() to handle an empty value.

Even though this method is never called (lol) it will be wrong once the configuration checking gets implemented.

@bernd
Copy link
Member

@bernd bernd commented Dec 22, 2016

I created an issue for the missing #checkConfiguration() invocations: #3236

@bernd
bernd approved these changes Dec 22, 2016
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd merged commit 6f9ef8d into master Dec 22, 2016
4 checks passed
4 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1198 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@bernd bernd deleted the issue-1512 branch Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants