Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special handling in SplitAndCountConverter #3230

Merged
merged 2 commits into from Dec 22, 2016
Merged

Remove special handling in SplitAndCountConverter #3230

merged 2 commits into from Dec 22, 2016

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Dec 21, 2016

Closes #3067

@joschi joschi added this to the 2.2.0 milestone Dec 21, 2016
@edmundoa edmundoa self-assigned this Dec 22, 2016
Copy link
Member

@edmundoa edmundoa left a comment

Other than the typo in the UPGRADING docs, looks good to me

+-------------+---------------+-----------+-------------+
| ``foo`` | ``-`` | 0 | 1 |
+-------------+---------------+-----------+-------------+
| ``foo-bar`` | ``-`` | 1 | 1 |

This comment has been minimized.

@edmundoa

edmundoa Dec 22, 2016
Member

This example would return 2 in both the new and old implementations.

@edmundoa edmundoa merged commit 5b933e2 into master Dec 22, 2016
1 of 3 checks passed
1 of 3 checks passed
@garybot2
ci-web-linter Jenkins build is being scheduled
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
licence/cla Contributor License Agreement is signed.
Details
@edmundoa edmundoa deleted the issue-3067 branch Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants