Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty row if input description is empty #3237

Merged
merged 2 commits into from Dec 22, 2016
Merged

Remove empty row if input description is empty #3237

merged 2 commits into from Dec 22, 2016

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Dec 22, 2016

Closes #2417

@joschi joschi added this to the 2.2.0 milestone Dec 22, 2016
@edmundoa edmundoa self-assigned this Dec 22, 2016
Copy link
Member

@edmundoa edmundoa left a comment

Other than the tiny space thing, it looks good to me.

@@ -25,12 +25,14 @@ const EntityListItem = React.createClass({
<Row className="row-sm">
<Col md={6}>
<h2>{this.props.title} {titleSuffix}</h2>
<div className="item-description">
{ (this.props.createdFromContentPack || this.props.description) &&

This comment has been minimized.

@edmundoa

edmundoa Dec 22, 2016
Member

As a really tiny nit-pick, the space after the curly brace here breaks the react/jsx-curly-spacing style rule.

@edmundoa edmundoa merged commit 3fe60e6 into master Dec 22, 2016
4 checks passed
4 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1201 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@edmundoa edmundoa deleted the issue-2417 branch Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants