Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly track stream throughput for the default stream #3278

Merged
merged 1 commit into from Jan 2, 2017
Merged

Conversation

@kroepke
Copy link
Member

@kroepke kroepke commented Jan 2, 2017

The default stream's throughput wasn't tracked during stream routing.

This change marks a message on the default stream's meter if it hasn't been removed by any other stream during normal routing.
Should a pipeline function manually route the message again, then the counter will be incremented twice, which is a known issue (and has existed prior to this change).

Best tested by a random message generator and two additional streams: "took_ms > 50" and "took_ms < 51". Both should remove the message from the default stream.
Selectively pausing the streams you will see the throughput numbers shift from the default stream (which wasn't working before) to each of the streams. If both are enabled, the default stream should not have any throughput anymore.

fixes #3184

@kroepke kroepke added this to the 2.2.0 milestone Jan 2, 2017
@bernd bernd self-assigned this Jan 2, 2017
bernd
bernd approved these changes Jan 2, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

Loading

@bernd bernd merged commit 726e10f into master Jan 2, 2017
4 checks passed
Loading
@bernd bernd deleted the issue-3184 branch Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants