Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move client-side split/import of Grok pattern files to server #3284

Merged
merged 2 commits into from Jan 4, 2017
Merged

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Jan 3, 2017

Fixes #3003

@joschi joschi added this to the 2.2.0 milestone Jan 3, 2017
@@ -108,3 +144,22 @@ export default function fetch(method, url, body) {
}
return promise();
}

export function fetchPlainText(method, url, body) {

This comment has been minimized.

@joschi

joschi Jan 3, 2017
Author Contributor

I'm a bit unhappy about this code duplication but didn't want to refactor the whole FetchProvider to generically support something other than application/json in this PR as it's being used in quite a few places…

@@ -130,6 +141,47 @@ public Response bulkUpdatePatterns(@ApiParam(name = "patterns", required = true)
}

@PUT

This comment has been minimized.

@bernd

bernd Jan 3, 2017
Member

I think this should be a @POST because it depends on the replace param if this method it idempotent.

@kroepke
kroepke approved these changes Jan 4, 2017
Copy link
Member

@kroepke kroepke left a comment

lgtm!

@kroepke kroepke merged commit 68f7840 into master Jan 4, 2017
4 checks passed
4 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1227 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@kroepke kroepke deleted the issue-3003 branch Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants