Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing index set in stream listing only if user is permitted to. #3300

Merged
merged 1 commit into from Jan 5, 2017

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jan 4, 2017

Description

This PR adds a check for the permission and the presence of the index
set definition in the component showing the stream summary, rendering
index set details only if both are present.

Motivation and Context

This is fixing an issue where it's implicitly assumed that a user
navigating to the streams page has the required permissions to list all
index sets. This might not be the case for non-admin users, leading to
the streams page breaking completely.

Fixes #3299.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
This is fixing an issue where it's implicitly assumed that a user
navigating to the streams page has the required permissions to list all
index sets. This might not be the case for non-admin users, leading to
the streams page breaking completely.

This PR adds a check for the permission and the presence of the index
set definition in the component showing the stream summary, rendering
index set details only if both are present.

Fixes #3299.
@joschi
joschi approved these changes Jan 5, 2017
Copy link
Contributor

@joschi joschi left a comment

Works for me. 👍

@joschi joschi merged commit 5e201fc into master Jan 5, 2017
4 checks passed
4 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1242 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@joschi joschi deleted the issue-3299 branch Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants