Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refreshing saved searches store after deleting one. #3309

Merged
merged 1 commit into from Jan 6, 2017
Merged

Refreshing saved searches store after deleting one. #3309

merged 1 commit into from Jan 6, 2017

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jan 6, 2017

Before this change, the saved searches store was not automatically
refreshed after triggering a successfull deletion. This lead to the
saved searches dropdown in the search bar being inconsistent.

This change triggers a refresh after a successfull deletion, so the
store and therefore the saved searches dropdown is accurate.

Fixes #2841.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Before this change, the saved searches store was not automatically
refreshed after triggering a successfull deletion. This lead to the
saved searches dropdown in the search bar being inconsistent.

This change triggers a refresh after a successfull deletion, so the
store and therefore the saved searches dropdown is accurate.

Fixes #2841.
bernd
bernd approved these changes Jan 6, 2017
@bernd bernd merged commit a37e304 into master Jan 6, 2017
4 checks passed
Loading
@bernd bernd deleted the issue-2841 branch Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants