Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved search improvements #3338

Merged
merged 4 commits into from Jan 11, 2017
Merged

Saved search improvements #3338

merged 4 commits into from Jan 11, 2017

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jan 11, 2017

This PR resets the field selection when the saved search changes, fixing #3071.

It also fixes some other small usability issues: updating the saved create/edit modal title input when the saved search is deleted or updated, and display the deleted saved search title in the delete notification (instead of undefined as it was).

edmundoa added 4 commits Jan 11, 2017
- When deleting a saved search, reset the title to an empty string.
- When changing the saved search, reset the title to the current saved
search title (or empty if no saved search is selected)
Code handling field selection is in the `SearchResult` component.
@edmundoa edmundoa added this to the 2.2.0 milestone Jan 11, 2017
@bernd bernd self-assigned this Jan 11, 2017
@bernd
bernd approved these changes Jan 11, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd merged commit 5fd6ade into master Jan 11, 2017
4 checks passed
4 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1264 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@bernd bernd deleted the saved-search-improvements branch Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants