New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Mongo indices in services which do conditional queries. #3345

Merged
merged 2 commits into from Jan 16, 2017

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Jan 12, 2017

In this PR, I am trying to create some MongoDB indices for services
doing conditional queries. I also took the chance and renamed the
alarm callback value/service class implementations and extracted field
constants being reused in several places.

This is probably not a complete fix for #2821, but it already helps a
bit.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Creating Mongo indices in services which do conditional queries.
In this PR, I am trying to create some MongoDB indices for services
doing conditional queries. I also took the chance and renamed the
alarm callback value/service class implementations and extracted field
constants being reused in several places.

This is probably not a complete fix for #2821, but it already helps a
bit.

@dennisoelkers dennisoelkers added this to the 2.2.0 milestone Jan 12, 2017

@joschi joschi self-assigned this Jan 13, 2017

@joschi

Should AlarmCallbackConfigurationServiceMJImplTest be merged into AlarmCallbackHistoryServiceImplTest or simply be deleted?

@dennisoelkers

This comment has been minimized.

Member

dennisoelkers commented Jan 16, 2017

Those test suites are for two different classes (AlarmCallbackConfigurationServiceImpl vs. AlarmCallbackHistoryServiceImpl). But I renamed the first one nonetheless and removed the MJ.

@joschi

joschi approved these changes Jan 16, 2017

@joschi joschi merged commit 0559ec1 into master Jan 16, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1283 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@joschi joschi deleted the issue-2821 branch Jan 16, 2017

@joschi

This comment has been minimized.

Contributor

joschi commented Jan 16, 2017

I decided to close #2821 with this PR. We can open another issue if we have problems with missing MongoDB indices again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment