Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt grace period to latest changes in alerts #3346

Merged
merged 1 commit into from Jan 13, 2017
Merged

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jan 12, 2017

As it is still not possible to mute alerts, we are keeping the grace period and updating the way it works:

Instead of calculating the grace period using the triggered_at time, we are changing it to use resolved_at. That means that the grace period will prevent to trigger a new alert once that alert is marked as resolved, helping to minimize the noise if a condition check is fluctuating too much.

Refs #3178

As it is still not possible to mute alerts, we are keeping the grace
period and updating the way it works:

Instead of calculating the grace period using the `triggered_at` time,
we are changing it to use `resolved_at`. That means that the grace period
will prevent to trigger a new alert once that alert is marked as resolved.
@edmundoa edmundoa added this to the 2.2.0 milestone Jan 12, 2017
@edmundoa edmundoa mentioned this pull request Jan 12, 2017
8 tasks done
@dennisoelkers dennisoelkers self-assigned this Jan 13, 2017
@dennisoelkers dennisoelkers self-requested a review Jan 13, 2017
Copy link
Member

@dennisoelkers dennisoelkers left a comment

LGTM!

@dennisoelkers dennisoelkers merged commit 7ee1cf4 into master Jan 13, 2017
4 checks passed
4 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1275 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@edmundoa edmundoa deleted the update-grace-period branch Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants