New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep stream filter after editing stream. #3352

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Jan 13, 2017

Description

Motivation and Context

Before this change, whenever a stream was edited and the stream form
modal was closed, the full list of streams was shown again, even if a
filter had been entered. Getting the filtered view again required
pressing the "filter" button.

After this change, whenver the stream form modal is closed, the stream
filter is maintained.

Fixes #2545

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Keep stream filter after editing stream.
Before this change, whenever a stream was edited and the stream form
modal was closed, the full list of streams was shown again, even if a
filter had been entered. Getting the filtered view again required
pressing the "filter" button.

After this change, whenver the stream form modal is closed, the stream
filter is maintained.

Fixes #2545

@dennisoelkers dennisoelkers added this to the 2.2.0 milestone Jan 13, 2017

@kroepke kroepke self-requested a review Jan 16, 2017

@kroepke

lgtm!

@kroepke kroepke merged commit 1540671 into master Jan 16, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1279 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@kroepke kroepke deleted the issue-2545 branch Jan 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment