New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep calling convention of SearchPage._refreshData consistent. #3357

Merged
merged 1 commit into from Jan 16, 2017

Conversation

Projects
None yet
2 participants
@dennisoelkers
Member

dennisoelkers commented Jan 16, 2017

SearchPage._refreshData is called from several places, internally from
the component and when actions of the Decorator dispatcher complete. In
the latter case, the parameter passed to _refreshData is wrong, it's the
decorator id instead of the stream id which scopes the current search.

This change wraps calling _refreshData from the dispatcher so the
parameter is correct.

Fixes #3355.

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Keep calling convention of SearchPage._refreshData consistent.
SearchPage._refreshData is called from several places, internally from
the component and when actions of the Decorator dispatcher complete. In
the latter case, the parameter passed to _refreshData is wrong, it's the
decorator id instead of the stream id which scopes the current search.

This change wraps calling _refreshData from the dispatcher so the
parameter is correct.

Fixes #3355.
@kroepke

This comment has been minimized.

Member

kroepke commented Jan 16, 2017

Hooray for untyped languages!

lgtm 😄

@kroepke kroepke merged commit fed5190 into master Jan 16, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1281 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@kroepke kroepke deleted the issue-3355 branch Jan 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment