New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-string fields to "contains" stream rule #3380

Merged
merged 1 commit into from Jan 18, 2017

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Jan 17, 2017

Description

In contrast to most other stream rules, the "contains" stream rule worked exclusively
on strings which can lead to surprising results if users try to match the contents of
a numeric or an array field.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Kind of both.
Add support for arrays to "contains" stream rule
In contrast to most other stream rules, the "contains" stream rule worked exclusively
on strings which can lead to surprising results if users try to match the contents of
a numeric or an array field.

@joschi joschi added the in progress label Jan 17, 2017

@joschi joschi changed the title from Add support for arrays to "contains" stream rule to Add support for non-string fields to "contains" stream rule Jan 17, 2017

@joschi joschi added ready-for-review and removed in progress labels Jan 18, 2017

@dennisoelkers dennisoelkers self-assigned this Jan 18, 2017

@dennisoelkers dennisoelkers merged commit 7bb61da into master Jan 18, 2017

4 checks passed

ci-web-linter Jenkins build graylog-pr-linter-check 1296 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@dennisoelkers dennisoelkers deleted the contains-matcher-array branch Jan 18, 2017

@joschi joschi added this to the 2.2.0 milestone Jan 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment