Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep modified search bar params when opening modal #3384

Merged
merged 1 commit into from Jan 18, 2017
Merged

Keep modified search bar params when opening modal #3384

merged 1 commit into from Jan 18, 2017

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jan 18, 2017

We now prevent the event propagation in the element opening the modal,
ensuring that if a link is used, the onclick event will not be propagated,
causing the browser to reset form inputs.

Fixes #3361

We now prevent the event propagation in the element opening the modal,
ensuring that if a link is used, the `onclick` event will not be propagated,
causing the browser to reset form inputs.

Fixes #3361
@edmundoa edmundoa added this to the 2.2.0 milestone Jan 18, 2017
@joschi joschi self-assigned this Jan 18, 2017
joschi
joschi approved these changes Jan 18, 2017
@joschi joschi merged commit 10d9aab into master Jan 18, 2017
3 checks passed
Loading
@joschi joschi deleted the issue-3361 branch Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants