Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken decorator with duplicate messages #3400

Merged
merged 2 commits into from Jan 20, 2017
Merged

Fix broken decorator with duplicate messages #3400

merged 2 commits into from Jan 20, 2017

Conversation

@bernd
Copy link
Member

@bernd bernd commented Jan 20, 2017

Use compound key when mapping messages in the decorator.

The same message with the same ID can be stored in two different index sets so to avoid duplicate keys when mapping messages, we have to use a compound key of the index name and the message ID.

Fixes #3399

bernd added 2 commits Jan 20, 2017
The same message with the same ID can be stored in two different index sets
so to avoid duplicate keys when mapping messages, we have to use a
compund key of the index name and the message ID.

Fixes #3399
@bernd bernd added this to the 2.2.0 milestone Jan 20, 2017
@kroepke kroepke self-assigned this Jan 20, 2017
@kroepke kroepke self-requested a review Jan 20, 2017
@@ -100,7 +106,7 @@ private SearchDecorationStats getSearchDecoratorStats(List<ResultMessageSummary>

decoratedMessages.forEach(message -> {
final DecorationStats decorationStats = message.decorationStats();
if (decoratedMessages != null) {
if (decorationStats != null) {

This comment has been minimized.

Copy link
Member

@kroepke kroepke left a comment

lgtm!

@kroepke kroepke merged commit b0d784c into master Jan 20, 2017
4 checks passed
4 checks passed
@garybot2
ci-web-linter Jenkins build graylog-pr-linter-check 1305 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@kroepke kroepke deleted the issue-3399 branch Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants