Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get field stats for indices only, which contain field. #3424

Merged
merged 4 commits into from Jan 26, 2017
Merged

Conversation

@dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jan 25, 2017

Description

Motivation and Context

Before this change, field stats for fields failed on shards of indices,
which do not contain the field. The error was buried in the result set
(instead of an explicit "all shards failed" error) when indices were
included in the query, which contain messages with the specified field,
but the aggregations (total, cardinality) failed and returned 0.

After this change, the field stats request checks which indices contain
the specified field and use those indices only.

There are also other places in the code which would probably require this check (histogram/terms stats), this needs verification and probably the creation of additional PRs.

Fixes #3402.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Before this change, field stats for fields failed on shards of indices,
which do not contain the field. The error was buried in the result set
(instead of an explicit "all shards failed" error) when indices were
included in the query, which contain messages with the specified field,
but the aggregations (total, cardinality) failed and returned 0.

After this change, the field stats request checks which indices contain
the specified field and use those indices only.

Fixes #3402.
@dennisoelkers dennisoelkers added the bug label Jan 25, 2017
@dennisoelkers dennisoelkers added this to the 2.2.0 milestone Jan 25, 2017
@edmundoa edmundoa self-assigned this Jan 25, 2017
@kroepke kroepke self-assigned this Jan 26, 2017
Copy link
Member

@kroepke kroepke left a comment

lgtm, thanks!

@kroepke kroepke merged commit c5509fd into master Jan 26, 2017
4 checks passed
4 checks passed
ci-web-linter Jenkins build graylog-pr-linter-check 1323 has succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@kroepke kroepke deleted the issue-3402 branch Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.